Skip to content

feat: add applied biosystems plate adapter#951

Open
jemancuso wants to merge 7 commits intoPyLabRobot:mainfrom
Pioneer-Research-Labs:add-applied-bio-plate-adapter
Open

feat: add applied biosystems plate adapter#951
jemancuso wants to merge 7 commits intoPyLabRobot:mainfrom
Pioneer-Research-Labs:add-applied-bio-plate-adapter

Conversation

@jemancuso
Copy link
Contributor

Add Applied Biosystems™ MicroAmp™ Splash-Free 96-Well Base, Item No.: 4312063
https://www.fishersci.com/shop/products/applied-biosystems-microamp-splash-free-96-well-base/4312063

@rickwierenga rickwierenga requested a review from BioCam March 20, 2026 22:16
@BioCam
Copy link
Collaborator

BioCam commented Mar 21, 2026

Hi @jemancuso,

Thank you very much for contributing this to PyLabRobot!

A couple of points to get this merged:

  1. PyLabRobot Resources are organised & named first by manufacturer. This avoids confusion about vendors and vendor-specific catalogue numbers masking the manufacturer's catalogue numbers.
    Applied Biosystems is not a company (anymore) but a brand owned by Thermo Fisher Scientific (see organisational structure in the PLR docs and screenshot below).
    That is the reason why PLR does not have and shouldn't have an "Applied Biosystems" folder
    -> please remove the folder and move the definition into /pylabrobot/resources/thermo_fisher

  2. The naming convention should be <manufacturer (lowercase, PLR-convention)>_<brand (PLR-convention)_<throughput>_<resource_type>_<miscellaneous identifier (a bit of a wildcard)
    -> I would suggest renaming to thermo_AB_96_plateadapter_MicroAmp?

  3. Please ensure that the first line of the docstrings specifies the catalogue number; example:

Screenshot 2026-03-21 at 17 53 16 (this is important for parsers and docstring consistency)
  1. Please provide the link to the manufacturer in the docstring too: https://www.thermofisher.com/order/catalog/product/4312063

Note: You may notice some inconsistencies in naming conventions in the existing codebase - this is a known legacy issue that is actively being cleaned up.
Please follow the conventions outlined above rather than using existing definitions as a reference.


Screenshot 2026-03-21 at 17 42 14

@BioCam
Copy link
Collaborator

BioCam commented Mar 21, 2026

@jemancuso, please feel free to ignore point 3 - it is a bit nitpicky 😂
The reason I do this is to enable classic parsers based on first line of docstring regular expression identification, but it's not essential

from .agenbio import *
from .agilent import *
from .alpaqua import *
from .applied_biosystems import *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants